fixing typo and improving cicd

Ximaz · May 2, 2024 · 6929bfe · 6929bfe
1 parent ff43f14
commit 6929bfe
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -2,12 +2,14 @@ name: "ci"
 
 on:
     -   push
+    -   pull_request
 
 env:
     UNIT_TESTS: "./unit_tests"
     VALGRIND_REPORTS: "./valgrind-reports.log"
     ARTIFACTS: "${{ vars.ARTIFACTS }}"
     MIRROR_URL: "${{ vars.MIRROR_URL }}"
+    VALGRIND_SUPPRESSIONS: "${{ vars.VALGRIND_SUPPRESSIONS }}"
     SSH_PRIVATE_KEY: "${{ secrets.SSH_PRIVATE_KEY }}"
     SSH_PRIVATE_KEY_PASSPHRASE: "${{ secrets.SSH_PRIVATE_KEY_PASSPHRASE }}"
 
@@ -128,8 +130,11 @@ jobs:
                 timeout-minutes: 1
                 run: "[[ $(grep -E \"^tests_run:\" Makefile) == \"\" ]] && exit 0 || make tests_run"
 
+            -   name: "Creating Valgrind suppression file"
+                run: "echo \"${{ env.VALGRIND_SUPPRESSIONS }}\" > valgrind.supp"
+
             -   name: "Run valgrind"
-                run: "[ -f \"${{ env.UNIT_TESTS }}\" ] && valgrind -s --leak-check=full --track-origins=yes --read-var-info=yes --trace-children=yes --show-leak-kinds=all --read-inline-info=yes --errors-for-leak-kinds=all ${{ env.UNIT_TESTS }} 2>${{ env.VALGRIND_REPORTS }}"
+                run: "[ -f \"${{ env.UNIT_TESTS }}\" ] && valgrind -s --leak-check=full --track-origins=yes --read-var-info=yes --trace-children=yes --show-leak-kinds=all --read-inline-info=yes --errors-for-leak-kinds=all --track-fds=yes --show-reachable=yes --gen-suppressions=all --suppressions=valgrind.supp ${{ env.UNIT_TESTS }} 2>${{ env.VALGRIND_REPORTS }}"
 
             -   name: "Analyze valgrind report"
                 run: |
@@ -148,6 +153,14 @@ jobs:
                         fi
                         if [[ $(echo "${line}" | grep '^==.*== .* bytes in .* blocks are definitely lost in loss record .* of .*$') ]]; then
                             block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== .* bytes in .* blocks are still reachable in loss record .* of .*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Invalid .* of size .*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== Open file descriptor .*: .*$') ]]; then
+                            block="${line}"
+                        elif [[ $(echo "${line}" | grep '^==.*== LEAK SUMMARY:.*$') ]]; then
+                            block="${line}"
                         fi
                     done < ${{ env.VALGRIND_REPORTS }}
                     exit "${status}"

diff --git a/Makefile b/Makefile
@@ -1,6 +1,6 @@
 ##
 ## EPITECH PROJECT, 2024
-## List in C
+## Hashmap in C
 ## File description:
 ## Makefile
 ##