[Refactor/#209] 테스트 컨테이너 및 액션 개선 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
force-pushed
the
refactor/#209_belljun3395
branch
from
417caec
to
e1f2e7c
Compare
belljun3395
force-pushed
the
refactor/#209_belljun3395
branch
from
b1e3dce
to
33d576b
Compare
belljun3395
force-pushed
the
refactor/#209_belljun3395
branch
5 times, most recently
from
6050fad
to
be97c6a
Compare
belljun3395
force-pushed
the
refactor/#209_belljun3395
branch
from
be97c6a
to
cda632b
Compare
belljun3395
changed the title
belljun3395
force-pushed
the
refactor/#209_belljun3395
branch
from
b03c32a
to
5bc7062
Compare
belljun3395
commented
Aug 8, 2024
|
|
||
| - name: Test with Gradle | ||
| run: | | ||
| ./gradlew --info test | ||
| ./gradlew test -parallel |
There was a problem hiding this comment.
전체 테스트를 수행하는 경우에는 병렬로 실행할 수 있도록 -parallel 옵션 추가하였습니다.
Comment on lines
+39
to
+57
| - name: Cache Api Repo Jooq | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ./api-repo/src/generated | ||
| ./api-repo/src/main/resources/db/migration | ||
| key: ${{ runner.os }}-api-repo-jooq-${{ hashFiles('./api-repo/src/generated/**', './api-repo/src/main/resources/db/migration/**') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-api-repo-jooq- | ||
|
|
||
| - name: Cache Batch Jooq | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ./batch/src/generated | ||
| ./batch/src/main/resources/db/migration | ||
| key: ${{ runner.os }}-batch-jooq-${{ hashFiles('./batch/src/generated/**', './batch/src/main/resources/db/migration/**') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-batch-jooq- |
There was a problem hiding this comment.
jooq 관련 파일을 캐싱합니다.
| restore-keys: | | ||
| ${{ runner.os }}-batch-jooq- | ||
|
|
||
| api-test: |
There was a problem hiding this comment.
아래 각각의 모듈 별로 필요한 캐싱된 값을 받아 테스트를 수행합니다.
| - "13306:3306" | ||
| - "33306:3306" |
There was a problem hiding this comment.
로컬 환경이 켜져있어도 테스트 수행할 수 있고
병렬로 테스트 수행하기 위해 포트를 변경해주었습니다.
-> 모듈별로 독립된 포트로
There was a problem hiding this comment.
이제 로컬에서 디비 컨태이너를 내리지 않고도 테스트가 가능하겠네요
Comment on lines
50
to
69
| /** Common */ | ||
| @Autowired | ||
| lateinit var apiControllerExceptionHandler: ApiControllerExceptionHandler | ||
|
|
||
| @Autowired | ||
| lateinit var objectMapper: ObjectMapper | ||
|
|
||
| lateinit var webTestClient: WebTestClient | ||
|
|
||
| @Autowired | ||
| lateinit var mockMvc: MockMvc | ||
|
|
||
| @MockBean | ||
| lateinit var tokenResolver: TokenResolver | ||
|
|
||
| /** AdminControllerTest */ | ||
| @Autowired | ||
| lateinit var adminController: AdminController | ||
|
|
||
| @MockBean |
There was a problem hiding this comment.
부모 테스트 클래스를 가지고 있어도
자식 클래스에 @MockBean이 들어가면 컨텍스트가 달라져 컨테이너가 다시 뜨는 문제가 있었어요!
그래서 @MockBean 클래스를 부모 클래스에서 주입 받도록 수정하였고
그김에 공통으로 사용하는 클래스 역시 부모 클래스에서 한번에 주입 받도록 수정하였습니다.
우선 수정은 하였는데 자세한 것은 추후 보충해서 공유할께요!
There was a problem hiding this comment.
https://youtu.be/N06UeRrWFdY?si=Exobuxb1xFS0NGoM
요 영상을 참고해서 수정하였어요!
There was a problem hiding this comment.
요건 다른 pr로 진행할께요
belljun3395
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #209
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
1m 18s -> 1m 5s
미미하지만 개선.. 하였습니다.
컨테이너가 한번만 떠야 환경을 위한 도커도 한번만 떠서 개선하였습니다.!
🤖 테스트 체크리스트