[Refactor/#360] 구독과 동시에 아티클 전송할 수 있도록 수정 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Aug 27, 2024
Comment on lines
+56
to
68
| /** | ||
| * 구독 이벤트 발행 | ||
| * @see com.few.api.domain.subscription.event.WorkbookSubscriptionEventListener | ||
| * @see com.few.api.domain.subscription.event.WorkbookSubscriptionAfterCompletionEventListener | ||
| */ | ||
| applicationEventPublisher.publishEvent( | ||
| WorkbookSubscriptionEvent( | ||
| workbookId = subTargetWorkbookId, | ||
| memberId = memberId, | ||
| articleDayCol = subscriptionStatus?.day ?: 1 | ||
| ) | ||
| ) | ||
| } |
There was a problem hiding this comment.
구독 이벤트를 발행합니다.
Comment on lines
-22
to
-37
| @Async(value = DISCORD_HOOK_EVENT_POOL) | ||
| @EventListener | ||
| fun handleWorkbookSubscriptionEvent(event: WorkbookSubscriptionEvent) { | ||
| val title = ReadWorkbookTitleInDto(event.workbookId).let { dto -> | ||
| workbookService.readWorkbookTitle(dto)?.workbookTitle | ||
| ?: throw NotFoundException("workbook.notfound.id") | ||
| } | ||
| subscriptionDao.countAllSubscriptionStatus().let { record -> | ||
| WorkbookSubscriptionArgs( | ||
| totalSubscriptions = record.totalSubscriptions, | ||
| activeSubscriptions = record.activeSubscriptions, | ||
| workbookTitle = title | ||
| ).let { args -> | ||
| subscriptionClient.announceWorkbookSubscription(args) | ||
| } | ||
| } |
There was a problem hiding this comment.
삭제된 설정은 Handler에서 설정하도록 수정하였습니다.
-> Handler 마다 별도의 설정이 가능하는 장점이 있다고 생각했어요
Comment on lines
+16
to
+17
| @TransactionalEventListener(phase = TransactionPhase.AFTER_COMPLETION) | ||
| @Transactional(propagation = Propagation.REQUIRES_NEW) |
There was a problem hiding this comment.
UC의 트랜잭션이 종료된 이후 새로운 트랜잭션을 생성하여 이벤트를 처리합니다.
Comment on lines
+60
to
+77
| runCatching { emailService.sendArticleEmail(it) } | ||
| .onSuccess { | ||
| val lastDayArticleId = ReadWorkbookLastArticleIdInDto( | ||
| workbookId | ||
| ).let { | ||
| workbookService.readWorkbookLastArticleId(it) | ||
| }?.lastArticleId ?: throw NotFoundException("workbook.notfound.id") | ||
|
|
||
| if (article.id == lastDayArticleId) { | ||
| UpdateArticleProgressCommand(workbookId, memberId).let { | ||
| subscriptionDao.updateArticleProgress(it) | ||
| } | ||
| } else { | ||
| UpdateLastArticleProgressCommand(workbookId, memberId).let { | ||
| subscriptionDao.updateLastArticleProgress(it) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
메일이 전송되면 진행을 +1 하는 로직입니다.
만약 전송된 날이 마지막 날이라면 구독을 종료합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #360
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트