Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koala-1245 | feat(convert-without-catalog): implementation & tests for convert without catalog #46

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

matanmichaely
Copy link

@matanmichaely matanmichaely commented Sep 1, 2024

Context

context was shared in this pr

Changes

  • In generator.py - added missing data type in Looker types dict
  • Under core package added the following with the relevant implementation , it's required for avoid usage of exposure logic
    • models.py
    • generator.py
  • Added unit tests for the new modules.

Prerequisites for integration test

  • For convert method under converter.py module "integration" test was added
  • Under tests/resources/core added expected_lookml & test_target folders
  • In expected_lookml and generated_lookml folders new generated Looker views were added.
  • In test_target/manifest.json I did the following changes
    • Update model columns' data type attribute from type -> data_type
    • For 7 models I added yoda_looker model tag (under config) which marks them as model for conversion.

@matanmichaely matanmichaely changed the title Koala-1245 | feat(convert-without-catalog): implementation & tests for convert without catalog. Koala-1245 | feat(convert-without-catalog): implementation & tests for convert without catalog Sep 1, 2024
@matanmichaely matanmichaely merged commit 1d4dbed into main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants