winhello: support u2f appid #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define fido_assert_set_winhello_appid(), a special-purpose function to pass a u2f appid to windows hello. this function is necessary because webauthn.dll does not allow authenticators to be probed silently, which is how u2f appids are handled in ctap. without fido_assert_set_winhello_appid(), the only way to support u2f appid on windows is to expose users to webauthn.dll's ux twice; once for each call to fido_dev_get_assert(3).
LDVG
approved these changes
Apr 12, 2023
kongeo
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define fido_assert_set_winhello_appid(), a special-purpose function to pass a u2f appid to windows hello. this function is necessary because webauthn.dll does not allow authenticators to be probed silently, which is how u2f appids are handled in ctap.
without fido_assert_set_winhello_appid(), the only way to support u2f appid on windows is to expose users to webauthn.dll's ux twice; once for each call to fido_dev_get_assert(3).
tested on windows 11 pro insider preview build 25324.rs_prerelease.230317-1418 with webauthn.dll version 5.