Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBP fiat currency integration #1338

Closed
marcondy opened this issue Feb 23, 2023 · 6 comments
Closed

LBP fiat currency integration #1338

marcondy opened this issue Feb 23, 2023 · 6 comments
Labels

Comments

@marcondy
Copy link

Describe the feature

It would be great to have integrated the real market rate of LBP ( Lebanese Lira )

API documentation

https://api.yadio.io/convert/1/BTC/LBP

Thank you in advance

@marcondy marcondy added the Feature request New feature request label Feb 23, 2023
@kaloudis
Copy link
Contributor

Currently we are limited to currency exchange rates provided by https://www.coingecko.com/

We would accept a PR that pulled in additional sources as long as those sources are clearly marked and the source is accurate and reliable.

@marcondy
Copy link
Author

Unfortunately there aren't many public API to my knowledge that reflects real LBP value vs USD besides yadio, all other exchange rates websites do not provide API , it would be messy to do html extract.

Google LBP rate is set by central bank, and that rate is "fake" unfortunately and many common converters use it as reference.

Therefore,yadio comes as closest to accurate and reliable source.

I've been using it personally for a while

@myxmaster
Copy link
Contributor

It would be really nice if users could choose where the rates come from.
Coingecko and yadio would be a good starting point, maybe others can be added later.

@marcondy
Copy link
Author

It would be really nice if users could choose where the rates come from. Coingecko and yadio would be a good starting point, maybe others can be added later.

Unfortunately coingecko uses google to get rates,and that rates for Lebanon LBP is not correct. There is a huge difference between reality and what central bank announces, does not reflect reality

@kaloudis
Copy link
Contributor

It would be really nice if users could choose where the rates come from. Coingecko and yadio would be a good starting point, maybe others can be added later.

Unfortunately coingecko uses google to get rates,and that rates for Lebanon LBP is not correct. There is a huge difference between reality and what central bank announces, does not reflect reality

Not to worry, we found a way to use Yadio #1373

@kaloudis
Copy link
Contributor

Added in v0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants