Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat currencies: new additions from Yadio #1373

Merged
merged 12 commits into from
Mar 16, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 14, 2023

Description

Relates to issue: ZEUS-1338

Restores:
🇮🇸 Icelandic Krona (ISK)

Adds:
🇱🇧 Lebanese Pound (LBP)
🇲🇾 Malaysian Ringgit (MYR)
🇺🇦 Ukrainian Hryvnia (UAH)
🇯🇲 Jamaican Dollar (JMD)
🇨🇴 Colombian Peso (COP)
🇲🇽 Mexican Peso (MXN)
🇹🇿 Tanzanian Shilling (TZS)
🇶🇦 Qatari Riyal (QAR)
🇹🇳 Tunisian Dinar (TND)
🇳🇴 Norwegian Krone (NOK)
🇦🇪 United Arab Emirates Dirham (AED)
🇹🇹 Trinidad & Tobago Dollar (TTD)
🇵🇭 Philippine Peso (PHP)
🇮🇩 Indonesian Rupiah (IDR)
🇷🇴 Romanian Leu (RON)
🇨🇩 Congolese Franc (CDF)
🇨🇲🇨🇫🇹🇩🇨🇬🇬🇶🇬🇦 Central African CFA franc (XAF)
🇰🇪 Kenyan Shilling (KES)
🇺🇬 Ugandan Shilling (UGX)
🇿🇦 South African Rand (ZAR)
🇨🇺 Cuban Peso (CUP)
🇩🇴 Dominican Peso (DOP)
🇧🇿 Belize Dollar (BZD)

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis marked this pull request as ready for review March 14, 2023 00:21
@kaloudis kaloudis changed the title Fiat currencies: restore ISK + add LBP, MYR, UAH, JMD, COP, MXN Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES Mar 14, 2023
@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS Mar 14, 2023
@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND Mar 14, 2023
@shubhamkmr04
Copy link
Contributor

tACK

@shubhamkmr04
Copy link
Contributor

shubhamkmr04 commented Mar 14, 2023

Are we gonna add more currencies in this PR?

@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD Mar 14, 2023
@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP Mar 14, 2023
@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP, IDR Mar 14, 2023
@kaloudis kaloudis changed the title Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP, IDR Fiat currencies: new additions from Yadio Mar 14, 2023
@kaloudis kaloudis merged commit 28129da into ZeusLN:master Mar 16, 2023
@kaloudis kaloudis deleted the fiat-additions branch March 16, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants