-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiat currencies: new additions from Yadio #1373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
changed the title
Fiat currencies: restore ISK + add LBP, MYR, UAH, JMD, COP, MXN
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES
Mar 14, 2023
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS
Mar 14, 2023
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND
Mar 14, 2023
tACK |
Are we gonna add more currencies in this PR? |
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD
Mar 14, 2023
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP
Mar 14, 2023
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP, IDR
Mar 14, 2023
kaloudis
changed the title
Fiat currencies: ISK, LBP, MYR, UAH, JMD, COP, MXN, VES, TZS, QAR, TND, NOK, AED, TTD, PHP, IDR
Fiat currencies: new additions from Yadio
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: ZEUS-1338
Restores:
🇮🇸 Icelandic Krona (ISK)
Adds:
🇱🇧 Lebanese Pound (LBP)
🇲🇾 Malaysian Ringgit (MYR)
🇺🇦 Ukrainian Hryvnia (UAH)
🇯🇲 Jamaican Dollar (JMD)
🇨🇴 Colombian Peso (COP)
🇲🇽 Mexican Peso (MXN)
🇹🇿 Tanzanian Shilling (TZS)
🇶🇦 Qatari Riyal (QAR)
🇹🇳 Tunisian Dinar (TND)
🇳🇴 Norwegian Krone (NOK)
🇦🇪 United Arab Emirates Dirham (AED)
🇹🇹 Trinidad & Tobago Dollar (TTD)
🇵🇭 Philippine Peso (PHP)
🇮🇩 Indonesian Rupiah (IDR)
🇷🇴 Romanian Leu (RON)
🇨🇩 Congolese Franc (CDF)
🇨🇲🇨🇫🇹🇩🇨🇬🇬🇶🇬🇦 Central African CFA franc (XAF)
🇰🇪 Kenyan Shilling (KES)
🇺🇬 Ugandan Shilling (UGX)
🇿🇦 South African Rand (ZAR)
🇨🇺 Cuban Peso (CUP)
🇩🇴 Dominican Peso (DOP)
🇧🇿 Belize Dollar (BZD)
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: