Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Configuration: some buttons should be labels #2189

Closed
myxmaster opened this issue May 11, 2024 · 1 comment
Closed

Node Configuration: some buttons should be labels #2189

myxmaster opened this issue May 11, 2024 · 1 comment
Milestone

Comments

@myxmaster
Copy link
Contributor

Describe your enhancement idea

In the Node Configuration screen there are NODE CONFIG SAVED and NODE ACTIVE buttons.

When you click NODE CONFIG SAVED, it saves the node config (although nothing was changed).
When you click NODE ACTIVE, it closes the settings.
-> Both doesn't make sense really/is not intuitive behaviour. Both buttons are just information, so no onPress action is needed and therefore they should be changed into labels.

@kaloudis kaloudis added this to the v0.9.1 milestone Aug 7, 2024
@kaloudis
Copy link
Contributor

kaloudis commented Aug 7, 2024

Completely agree.

NODE CONFIG SAVED should never be displayed. We should just hide it if there are no changes.

NODE ACTIVE should be a badge of sorts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants