Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-2189: Node Configuration: some buttons should be labels #2366

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

kaloudis
Copy link
Contributor

Description

Relates to issue: ZEUS-2189

This includes two changes:

  • NODE CONFIG SAVED is now never be displayed. If there are no changes, the Save button is hidden
  • NODE ACTIVE is now a label, and placed above the action buttons

Before:
Simulator Screenshot - iPhone 15 Plus - 2024-08-26 at 14 10 06

After:
Simulator Screenshot - iPhone 15 Plus - 2024-08-26 at 14 20 04

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added the Design Issue relating to design label Aug 26, 2024
@kaloudis kaloudis added this to the v0.9.1 milestone Aug 26, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1724743967
So we got what we needed but the text node active here, we gotta think about it, it looks too random

@kaloudis kaloudis merged commit 2038227 into ZeusLN:master Sep 15, 2024
3 checks passed
@kaloudis kaloudis deleted the zeus-2189 branch September 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issue relating to design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants