-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receive via NFC #1251
Receive via NFC #1251
Conversation
const { lnurlParams } = props; | ||
const { memo } = lnurlParams.defaultDescription; | ||
|
||
if (Number(amount) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job on this decision here. would be nice to have a comment explaining this though
have we tested this against lnurl-w's with ranges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment in there and also cleaned up the commit history to squash prettier commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against a card with a rang of 1-362560 and a card with 1.1-1.1
nit: we be nice if we squashed your prettier commits. it can be a pain to get the rewind workflow down but it can make a big difference when going back through old changes |
If it already doesn't – would it be possible to make this work also for lud17 raw links? It looks like this: Instead of bech32 decoding you only replace lnurlw:// with https:// and rest is just the same. These raw withdraw links are used by Bolt cards. |
That should already be covered in a previous PR I made |
Awesome! Thanks for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updated Receive screen to include NFC support. If an amount has been entered payment for this amount will automatically be requested on scanning. If no amount has been entered the create invoice screen will be displayed.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andpackage-lock.json
have been properly updatedOther: