-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: Payments: allow the user to change their default fee limit #1256
Settings: Payments: allow the user to change their default fee limit #1256
Conversation
feeOption: 'sats', | ||
feeOption: 'fixed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved type-safety, maybe we should use an enum for this and update the InvoiceState and PaymentSettings interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this. Spoke with Ovidio and agreed to tackle enums more broadly - throughout the app - in another issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking here: #1262
tACK. Great job, Ovidio!! |
@Ovifer13 merging this in with squashed commits. When you have some time again I'd like to teach you how to restructure your commits. This will make review of code much easier and make for cleaner PRs. Nonetheless, great work. Will get users testing this ASAP. |
Description
Relates to issue: ZEUS-#1106
Creation of the payments tab where users will be able to change their default fee
Video example
https://www.loom.com/share/2b40ab71f4d4408b8f6382317f0f8350
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andpackage-lock.json
have been properly updatedOther: