-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point of Sale: Square integration #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { getRate, loading } = FiatStore; | ||
const { item } = order; | ||
return ( | ||
<TouchableHighlight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- While fiat rate was being fetched the order couldn't be viewed but it wasn't entirely obvious why... maybe touchability needs to be disabled while rates are loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be covered by the flashing Fetching fiat rates
at the top of the screen but will revisit if there's confusion out in the field
dda9d81
to
4f56ef8
Compare
eab74cc
to
933e154
Compare
Just one more item I have found this morning. I created an invoice and paid the invoice by switching between apps on the same device. It looks like because of that the order didn't get marked as paid even though the invoice was paid. This was using LND over clearnet. Maybe there's a bug or perhaps it needs a way to manually mark an order as paid just as a fallback? |
@Talej I think the listener gets killed when you navigate away from it. Will evaluate it. Will assess this weekend whether to build the mark function into the UI or if it's OK to just have staff do that from the Square terminal. Likely needs an admin menu. |
Description
This PR adds a Point of Sale interface for Square terminals
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andpackage-lock.json
have been properly updatedOther: