Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: run simulator on Ventura 13.2 without Rosetta #1289

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

joegesualdo
Copy link
Contributor

Description

Relates to issue: ZEUS-0000

I wasn't able to build on my M1 Macbook Air after I updated to Ventura. These changes get it building correctly in the simulator, with the added benefit of working without enabling XCode to open with Rosetta.

Here are the two things I changed:

  1. Changed Excluded Architecture for the Simulator from i386 to arm64 in both the zeus and zuesTests targets.

Screenshot 2023-01-31 at 4 29 29 PM

  1. Added a script to the Podfile to update all the pods in the same way.

NOTE: I'm not sure how this would work for OS versions before Ventura, so that would need to be tested - without Rosetta enabled.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS - Ventura 13.2 running IPhone 14 Simulator.

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor

WOW - massively helpful

@kaloudis kaloudis changed the title Get simulator building on M1 MacOS Ventura 13.2 without Rosetta. MacOS: run simulator on Ventura 13.2 without Rosetta Feb 10, 2023
@kaloudis
Copy link
Contributor

On Monterrey I'm hitting this issue when trying to build for iPhone 11: Command PhaseScriptExecution failed with a nonzero exit code

@joegesualdo
Copy link
Contributor Author

@kaloudis I'd try the following:

  • Delete node_modules directory
  • Delete ios/Podfile.lock file
  • Delete ios/Pods directory
  • Delete derived data: rm -r ~/Library/Developer/Xcode/DerivedData
  • Delete workspace file: rm ./ios/zeus.xcworkspace
  • Reinstall node deps: yarn install
  • Reinstall ios deps: pod install

Then try building again.

If you still get the error, I can look into it more.

@kaloudis
Copy link
Contributor

kaloudis commented Mar 5, 2023

@kaloudis I'd try the following:

* Delete `node_modules` directory

* Delete `ios/Podfile.lock` file

* Delete `ios/Pods` directory

* Delete derived data: `rm -r ~/Library/Developer/Xcode/DerivedData`

* Delete workspace file: `rm ./ios/zeus.xcworkspace`

* Reinstall node deps: `yarn install`

* Reinstall ios deps: `pod install`

Then try building again.

If you still get the error, I can look into it more.

Did all of the above minus deleting the .xcworkspace and it worked. Nice job!

kaloudis
kaloudis previously approved these changes Mar 5, 2023
@joegesualdo
Copy link
Contributor Author

Awesome!

@kaloudis
Copy link
Contributor

kaloudis commented Mar 5, 2023

@joegesualdo could you just modify this line to remove the Rosetta note?

zeus/README.md

Line 124 in 6033042

4. open `ios/zeus.xcworkspace` in Xcode and hit Run. NOTE: if you're using an M1 mac, you may need to right click Xcode > get info > check `Open using Rosetta` before opening `zeus.xcworkspace`.

@joegesualdo
Copy link
Contributor Author

README has been updated and branch has been rebased.

@kaloudis kaloudis merged commit 560612b into ZeusLN:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants