-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS: run simulator on Ventura 13.2 without Rosetta #1289
Conversation
WOW - massively helpful |
On Monterrey I'm hitting this issue when trying to build for iPhone 11: |
@kaloudis I'd try the following:
Then try building again. If you still get the error, I can look into it more. |
Did all of the above minus deleting the |
Awesome! |
@joegesualdo could you just modify this line to remove the Rosetta note? Line 124 in 6033042
|
48c2c81
to
0487c0f
Compare
README has been updated and branch has been rebased. |
Description
Relates to issue: ZEUS-0000
I wasn't able to build on my M1 Macbook Air after I updated to Ventura. These changes get it building correctly in the simulator, with the added benefit of working without enabling XCode to open with Rosetta.
Here are the two things I changed:
i386
toarm64
in both thezeus
andzuesTests
targets.This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: