Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee Bumping #1368

Merged
merged 14 commits into from
Mar 15, 2023
Merged

Fee Bumping #1368

merged 14 commits into from
Mar 15, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 13, 2023

Description

This PR adds support for bumping fees with LND using three use cases:

  • On-chain transactions (from the activity > transaction view)
  • Pending open channels (from the channel view)
  • Pending close channels (as a TX from the activity > transaction view)

Screenshot_1678830321
Screenshot_1678830318
Screenshot_1678830311
Screenshot_1678830298
Screenshot_1678830294
Screenshot_1678830291

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis changed the title Fee Bump Fee Bumping Mar 14, 2023
@kaloudis kaloudis marked this pull request as ready for review March 14, 2023 21:45
locales/en.json Outdated
"views.BumpFee.titleAlt": "Speed up channel open",
"views.BumpFee.targetConfs": "Target confirmations",
"views.BumpFee.success": "Succesfully bumped fee!",
"views.BumpFee.error": "Error buumping fee",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need Rocket.svg anymore?

@shubhamkmr04
Copy link
Contributor

tACK

@kaloudis kaloudis merged commit 0b4823b into ZeusLN:master Mar 15, 2023
@kaloudis kaloudis deleted the fee-bump branch March 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants