Bug fix: locking when going to background #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
reviewed
Jun 3, 2023
| @@ -350,7 +353,7 @@ export default class Wallet extends React.Component<WalletProps, WalletState> { | |||
| const error = NodeInfoStore.error || SettingsStore.error; | |||
| const { implementation, settings, loggedIn, connecting, posStatus } = | |||
| SettingsStore; | |||
| const loginRequired = SettingsStore.loginRequired(); | |||
| const loginRequired = !settings || SettingsStore.loginRequired(); | |||
There was a problem hiding this comment.
why require login if no settings here?
There was a problem hiding this comment.
This prevents rendering potentially sensitive information when settings are not loaded yet and we don't know if login is required.
There was a problem hiding this comment.
have you tested the behavior on a fresh install here? feel like this would break something
There was a problem hiding this comment.
Just checked it by clearing storage and running Zeus again, configured the node and it worked.
kaloudis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The commit 22a9c8c broke the setting "Require login after app returns from background" because it did not logout when the user was logged in. Not sure if this breaks FaceID again because I can't test it on iOS.
Also fixed an error when pressing back while on POS screen in certain situations.
Additionally removed some unnecessary
awaits.This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: