Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back up wallet: order seed phrase in columns and center #1779

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

kaloudis
Copy link
Contributor

Description

This PR takes the seed phrase on the Back up wallet view, lays it out in columns instead of rows, and centers it all.

Columns is the far more common layout that I've seen across hardware wallets and seed plates.

iPhone 15 Pro Max - Before

Simulator Screenshot - iPhone 15 Pro Max - 2023-10-17 at 22 07 41

iPhone 15 Pro Max - After

Simulator Screenshot - iPhone 15 Pro Max - 2023-10-17 at 22 07 53

iPhone SE (3rd generation) - Before

Simulator Screenshot - iPhone SE (3rd generation) - 2023-10-17 at 22 06 43

iPhone SE (3rd generation) - After

Simulator Screenshot - iPhone SE (3rd generation) - 2023-10-17 at 22 06 26

iPad Pro (12.9-inch) (6th generation) - Before

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-10-17 at 22 02 07

iPad Pro (12.9-inch) (6th generation) - After

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-10-17 at 22 01 50

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor Author

Made one more change to hang the phrases closer to the left, leaving less of a gap between the index number and the word:

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-10-18 at 10 36 37
Simulator Screenshot - iPhone 15 Pro Max - 2023-10-18 at 10 34 59

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit e30204f into ZeusLN:master Oct 20, 2023
3 checks passed
@kaloudis kaloudis deleted the seed-columns branch October 20, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants