Contacts: Saving banner and photos locally #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamkmr04
changed the title
shubhamkmr04
changed the title
shubhamkmr04
force-pushed
the
shubham/download-images-before-importing
branch
from
b65e372
to
184b093
Compare
kaloudis
reviewed
Jan 18, 2024
views/NostrContacts.tsx
Outdated
| banner: contact?.banner, | ||
| isSelected: false | ||
| }; | ||
| transformContactData = async (contact: any) => { |
There was a problem hiding this comment.
since transformContactData is used across files perhaps we should make a ContactUtils
kaloudis
reviewed
Jan 18, 2024
package.json
Outdated
| @@ -99,6 +99,7 @@ | |||
| "react-native-draglist": "3.5.1", | |||
| "react-native-elements": "3.4.3", | |||
| "react-native-encrypted-storage": "4.0.3", | |||
| "react-native-fs": "^2.20.0", | |||
There was a problem hiding this comment.
let's lock in the version here
shubhamkmr04
force-pushed
the
shubham/download-images-before-importing
branch
from
9d46101
to
49383b5
Compare
…ore than 1 contact
shubhamkmr04
force-pushed
the
shubham/download-images-before-importing
branch
from
2a20454
to
698fc29
Compare
kaloudis
reviewed
Jan 20, 2024
utils/ContactUtils.test.ts
Outdated
| isSelected: false | ||
| }); | ||
| }); | ||
| it('transforms contact data properly', async () => { |
There was a problem hiding this comment.
change the title here or put the tests in the same block
kaloudis
reviewed
Jan 20, 2024
| jest.mock('react-native-fs', () => ({ | ||
| DocumentDirectoryPath: '/mocked/document/directory', | ||
| downloadFile: jest.fn(() => ({ promise: Promise.resolve() })) | ||
| })); |
There was a problem hiding this comment.
is this required if we're not processing any images?
There was a problem hiding this comment.
Yes, it is not required for now, but unknowingly, we get issues in the test when this mock is removed, so I decided to keep it as it will be helpful in our future implementations.
shubhamkmr04
force-pushed
the
shubham/download-images-before-importing
branch
from
698fc29
to
ba50451
Compare
kaloudis
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.