RNFS: account for changing DocumentDirectoryPath #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,7 +67,7 @@ const transformContactData = async (contact: any) => { | |||
| }).promise; | |||
|
|
|||
| console.log('Download successful!'); | |||
| transformedContact.photo = 'file://' + filePath; | |||
| transformedContact.photo = 'rnfs://' + fileName; | |||
There was a problem hiding this comment.
I wonder if we should also do such changes in selectPhoto of AddContact.tsx ?
kaloudis
force-pushed
the
rnfs-handle-changing-dir-
branch
from
360ccfd
to
eac727a
Compare
kaloudis
force-pushed
the
rnfs-handle-changing-dir-
branch
from
eac727a
to
2e5bebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue with Contacts images on iOS. With iOS design, the
DocumentDirectoryPathchanges with each update. This would cause our saved images to break upon update.Related issue: itinance/react-native-fs#528
This PR ensures that images persist across app updates.