Display currencies sorted

[myxmaster]

Description

Currencies are now displayed sorted by key (name, not code).

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[shubhamkmr04]

Since the US Dollar is in the end of the list now, I think we should either change the value to United States Dollar in CURRENCY_KEYS of SettingsStore or change the search logic so we can also search it with Us
cc: @kaloudis

[kaloudis]

Since the US Dollar is in the end of the list now, I think we should either change the value to United States Dollar in CURRENCY_KEYS of SettingsStore or change the search logic so we can also search it with Us cc: @kaloudis

yes, search should take the currency codes into account

[myxmaster]

I can't reproduce the problem. I get US Dollar when searching US or USD or US Dollar:

[shubhamkmr04]

Try searching for Us as in first letter capital. it happens by default on iOS

[myxmaster]

Should be fixed now.

[kaloudis]

tACK