Embedded LND: revamped wallet recovery process

[kaloudis]

Description

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-05.at.22.10.49.mp4

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[kaloudis]

This needs to be tested with a SCB

[shubhamkmr04]

Getting this bug in both iOS and android

Screen.Recording.2024-02-21.at.6.49.46.PM.mov

Screen.Recording.2024-02-21.at.6.50.12.PM.mov

[shubhamkmr04]

Words are not aligned properly

[shubhamkmr04]

Also, I think in the main TextInput here, headings like numbers 1,2,3 and SCB should be highlighted

[shubhamkmr04]

In the Disaster Recovery Data input, is it supposed to start writing after the placeholder text ?

[shubhamkmr04]

in android, we are not getting option to restore the wallet, is this expected?

[shubhamkmr04]

And in iOS, I guess we should be getting prefilled testnet in the dropdown in this case

[shubhamkmr04]

Rest of the reviewed UI changes looks better than before

[kaloudis]

In the Disaster Recovery Data input, is it supposed to start writing after the placeholder text ?

intentional

[kaloudis]

@shubhamkmr04 I can't seem to recreate the two issues you detailed above. can you please clear your cache and try to run it on both platforms again?

[shubhamkmr04]

Tried that as well, Its fixed for iOS but still getting on android

For the context, Its only happening when I try to edit some other node like LNDHub, it won't happen if I fresh start to create a embedded node

[kaloudis]

Tried that as well, Its fixed for iOS but still getting on android For the context, Its only happening when I try to edit some other node like LNDHub, it won't happen if I fresh start to create a embedded node

can you try a cd android && ./gradlew clean?

[shubhamkmr04]

Tried that as well, Its fixed for iOS but still getting on android For the context, Its only happening when I try to edit some other node like LNDHub, it won't happen if I fresh start to create a embedded node

can you try a cd android && ./gradlew clean?

I tried everything including reinstalling app. But I think we can go ahead with this PR for now, and we can track of this as a separate issue