Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded LND: Settings > Advanced > Restore channel backups from clipboard #1986

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Feb 19, 2024

Description

This PR adds the ability for embedded node users to restore from channel backups after initial wallet recovery.

simulator_screenshot_C7C177F8-3D11-4CAB-B97E-EA3E71392BCB

simulator_screenshot_97B1EA97-F7C5-4CE7-85F2-62E4B89CA563

simulator_screenshot_84FE26AB-5731-478E-A865-81AE1F522697

simulator_screenshot_FB5C27B0-F7C2-4FA8-AEC9-5913C7971A7B

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.8.2 milestone Feb 19, 2024
@kaloudis
Copy link
Contributor Author

Will likely move the link to the Disaster recovery page

@kaloudis
Copy link
Contributor Author

Before:
simulator_screenshot_7EA36C8F-0B67-4115-8187-CCD50E18EA00

After:
simulator_screenshot_C7C177F8-3D11-4CAB-B97E-EA3E71392BCB

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1708946513
TextInput in android looks too big, maybe we can remove multiline and numberOfLines={3} to solve that

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1708947241
We can give some marginTop to the error message

@kaloudis kaloudis changed the title Embedded LND: Settings > Advanced > Restore channel backups Embedded LND: Settings > Advanced > Restore channel backups from clipboard Feb 26, 2024
@kaloudis kaloudis merged commit a09ccc4 into ZeusLN:master Feb 26, 2024
3 checks passed
@kaloudis kaloudis deleted the restore-chan-backups branch February 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants