Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed several problems and improved back press handling of Send screen.
First problem (#1974): When balance is 0, the send button is enabled although sending cannot succeed.
Second problem: When a destination is entered and proceed is clicked, you can change the destination afterwards to another type (BTC <-> LN), but the dialog does not adjust to the new destination type.
Fixed the first problem by disabling the send button if balance is zero.
Fixed the second problem by making the destination read-only after proceed is clicked. To change the destination, the user now can go back which now clears the input and allows entering a new destination. However, if the Send screen was entered by scanning a QR code or from the Contacts screen, the back button still closes the Send screen.
Before:
Same address, different (wrong) destination type:
After:
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: