-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded LND: Keysend: fix fee rate #2016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
force-pushed
the
embedded-lnd-keysend
branch
2 times, most recently
from
March 2, 2024 10:08
8ffca5c
to
d21886a
Compare
kaloudis
force-pushed
the
embedded-lnd-keysend
branch
2 times, most recently
from
March 4, 2024 15:06
5efe46b
to
a7afedd
Compare
kaloudis
force-pushed
the
embedded-lnd-keysend
branch
6 times, most recently
from
March 5, 2024 05:12
c7c4009
to
a373e3d
Compare
kaloudis
force-pushed
the
embedded-lnd-keysend
branch
from
March 5, 2024 06:06
a373e3d
to
bf434e7
Compare
shubhamkmr04
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shubhamkmr04
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2024-03-05.at.8.23.32.PM.mov
This flow looks a little glitchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users were reporting that with the embedded LND node, keysends weren't working unless a direct channel was established to the receiving peer.
The problem was two fold:
This PR remedies both issues. This PR also:
FeeLimit
componentc-lightning-REST
LN payments to use fee percentagec-lightning-REST
users to set their default max fee percentage on thePayment settings
viewPayment request
viewSending Lightning
viewSend
viewBefore:
After:
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: