Keep navigation state when resuming from background and login is required #2122
Conversation
| // In case the lock screen is visible and a valid PIN is entered and home button is pressed, | ||
| // unauthorized access would be possible because the PIN is not cleared on next launch. | ||
| // By calling pop, the lock screen is closed to clear the PIN. | ||
| this.props.navigation.pop(); |
There was a problem hiding this comment.
Fixed the issue but now we are having the issue as described in the comments here, we can come back to the zeus after typing in the correct passphrase and it will still be there
There was a problem hiding this comment.
Did you test and see that behaviour?
I am asking because that should definitely not happen (and I couldn't see that behaviour on Android emulator) because we are clearing the PIN: 8fc49c6#diff-8ba14cc97d1ffca67c674c4b343e6d0b0e8acbccc783040df6bdcc9db2186602R43
There was a problem hiding this comment.
that's happening with passphrases in both android and iOS emulator
Screen.Recording.2024-04-15.at.7.35.11.PM.mov
There was a problem hiding this comment.
Ah of course, you are right. Passphrase is not cleared, only PIN... So we need to take care of Passphrase too.
There was a problem hiding this comment.
Done. Also fixed the conflicts.
Additionally now navigating directly to intro splash when nodes are removed (duress pin/passphrase entered or too many failed login attempts).
myxmaster
force-pushed
the
keep-nav-state-on-lock
branch
from
3473b4e
to
a261974
Compare
…etting 'Select node on startup'
Description
This fixes #1880.
In Lockscreen, after successful login, we navigated to Wallet. Also, when going to background, we called
navigation.pop()to close a possibly open PIN screen. Both caused that the navigation state was lost.Instead we now call
navigation.pop()after successful login in Lockscreen and clear the entered pin in PinPad when going to background.This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: