Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency conversion: add XAG + XAU #2123

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

shivamgupta2020
Copy link
Contributor

Added XAG+ XAU currency.
Tried to fix #2113

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires changes in stores/FiatStore.ts as well.
Have a look at #1960 for the reference

@shivamgupta2020
Copy link
Contributor Author

For that, I was confused with what symbol should we use for XAG and XAU.
From what I searched, can we use Silver for XAG and Gold for XAU?

@shubhamkmr04
Copy link
Contributor

Probably yes.
@kaloudis thoughts ?

For that, I was confused with what symbol should we use for XAG and XAU. From what I searched, can we use Silver for XAG and Gold for XAU?

@kaloudis
Copy link
Contributor

kaloudis commented Apr 16, 2024

Good, question: oz AU / oz AG since the price is in ounces? rtl true

@shubhamkmr04
Copy link
Contributor

@shivamgupta2020 We have some failing tests in commits. Reset and force push them again

@kaloudis
Copy link
Contributor

@shivamgupta2020 moving forward you may want to also cut PRs from a new branch, instead of master. It doesn't make a difference to us but it will be much easier for you if you're managing multiple contributions

stores/FiatStore.ts Outdated Show resolved Hide resolved
@kaloudis kaloudis added this to the v0.9.0 milestone Apr 16, 2024
stores/FiatStore.ts Outdated Show resolved Hide resolved
@shivamgupta2020
Copy link
Contributor Author

@shivamgupta2020 moving forward you may want to also cut PRs from a new branch, instead of master. It doesn't make a difference to us but it will be much easier for you if you're managing multiple contributions

I will take care of your advice in my future contributions. Thanks for your valuable input @kaloudis.

@kaloudis kaloudis changed the title added XAG+XAU Currency conversion: add XAG + XAU Apr 17, 2024
@kaloudis kaloudis merged commit bb3ecf9 into ZeusLN:master Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add XAU + XAG exchange rates
3 participants