POS: Add Delete Product btn and remove the icon #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamkmr04
force-pushed
the
shubham/POS-delete-product-btn
branch
from
1cb7165
to
e04e82d
Compare
|
@shubhamkmr04 can you provide before and after screenshots? |
Yes, updated the description! |
kaloudis
requested changes
May 24, 2024
views/POS/ProductDetails.tsx
Outdated
| ) | ||
| } | ||
| onPress={() => { | ||
| if (!this.state.confirmDelete) { |
There was a problem hiding this comment.
nit: since we're referencing this.state.confirmDelete twice, let's destructure it on 227
shubhamkmr04
force-pushed
the
shubham/POS-delete-product-btn
branch
from
e04e82d
to
6fe5952
Compare
kaloudis
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2199
Before:
After:
