New screen: On-chain addresses #2242

myxmaster · 2024-06-15T13:25:30Z

Description

This adds "On-chain addresses" to the menu:

This displays all addresses from LND's ListAddresses grouped by account and address type. Allows hiding 0-balance addresses and sorting by creation time and balance.

This pull request is categorized as a:

Checklist

I’ve run yarn run tsc and made sure my code compiles correctly
I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
I’ve run yarn run prettier and made sure my code is formatted correctly
I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

No, I’m a fool
Yes
N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

Android
iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

Locales

I’ve added new locale text that requires translations
I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

Contributors will need to run yarn after this PR is merged in
3rd party dependencies have been modified:
- verify that package.json and yarn.lock have been properly updated
- verify that dependencies are installed for both iOS and Android platforms

Other:

Changes were made that require an update to the README
Changes were made that require an update to onboarding

myxmaster · 2024-08-14T18:24:23Z

Now additionally grouping change addresses:

kaloudis · 2024-08-28T02:47:21Z

We gotta change the icon. Currently it's credit cards?

kaloudis · 2024-09-18T15:08:00Z

Dropdown values not displaying correctly on iOS

views/OnChainAddresses.tsx

kaloudis · 2024-09-18T15:14:36Z

We need to configure this for Lightning Node Connect and Embedded LND as well

kaloudis · 2024-09-18T15:15:04Z

This view should also probably just replace the current Coins view

kaloudis · 2024-09-18T15:15:41Z

Lastly, we should think about adding the ability for users to pick the account they want to generate addresses for

kaloudis

see comments above

kaloudis · 2024-09-18T15:26:31Z

I think the sections should be collapsible (perhaps by default) - that way users will be able to navigate more easily if they have a ton of addresses

backends/LND.ts

kaloudis · 2024-09-22T02:47:36Z

views/OnChainAddresses.tsx

+
+    private loadAddresses = async () => {
+        this.setState({ loading: true });
+        const listAddressesResponse = await BackendUtils.listAddresses();


we should probably move this call to the UTXOsStore

Also, I think this is problematic. Fetching all addresses at once can lead to timeouts on nodes that have a bunch generated. Instead, I think it would be better to fetch the accounts list and then fetch the addresses for each account, one at a time.

We'd have to refactor quite a bit, but I don't think things will hold up as is.

kaloudis · 2024-09-22T02:50:23Z

This view should also probably just replace the current Coins view

after giving some thought to this, I think if supportsAddressesWithDerivationPaths - then we should show this new view, otherwise show the old view.

In keeping in sync with the Coins button under the On-chain balance slider, we should label the button on the Menu view Coins as well, and use the same icon.

kaloudis · 2024-09-25T02:01:25Z

Tons of changes wired up:

All three LND interfaces wired up
Error handling for timed out ListAddresses call
Ability to collapse address groups
Ability to generate addresses for each address group
Address count added to each address group header
Menu icon reverted to Coins icon

views/OnChainAddresses.tsx

shubhamkmr04

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-26.at.17.03.06.mp4

I think hide 0-balance should not remove the complete view in case we only have o-balance addresses

shubhamkmr04

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-26.at.17.10.42.mp4

the view glitch when we tap to add

kaloudis · 2024-09-26T16:02:24Z

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-26.at.17.10.42.mp4

the view glitch when we tap to add

I think we need a separate issue for this. Mind filing one?

shubhamkmr04

should we have one option here to generate in case we have no addresses?

shubhamkmr04 · 2024-09-27T14:29:38Z

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-26.at.17.10.42.mp4
the view glitch when we tap to add

I think we need a separate issue for this. Mind filing one?

we can track the issue here #2441

kaloudis · 2024-09-27T14:36:55Z

should we have one option here to generate in case we have no addresses?

Create button now added to the corner when no addresses have been generated yet

shubhamkmr04

tACK

kaloudis added this to the v0.9.1 milestone Jul 18, 2024

myxmaster force-pushed the on-chain-addresses branch 2 times, most recently from e712673 to bd7e3ca Compare August 14, 2024 18:21

kaloudis mentioned this pull request Aug 30, 2024

See history of generated receiving on-chain addresses #1930

Open

kaloudis reviewed Sep 18, 2024

View reviewed changes

views/OnChainAddresses.tsx Outdated Show resolved Hide resolved

kaloudis requested changes Sep 18, 2024

View reviewed changes

kaloudis reviewed Sep 22, 2024

View reviewed changes

backends/LND.ts Show resolved Hide resolved

kaloudis reviewed Sep 22, 2024

View reviewed changes

created OnChainAddresses screen

a4a895c

kaloudis force-pushed the on-chain-addresses branch from bd7e3ca to a4a895c Compare September 24, 2024 16:31

kaloudis added 8 commits September 24, 2024 12:47

OnChainAddresses: fix display of sort keys on iOS

0c5fba3

Backends: flesh out supportsAddressesWithDerivationPaths

81699e3

OnChainAddresses: AddressGroup: make collapsible + add count

4a7c6ca

OnChainAddresses: refactor listAddresses call

2642bf9

OnChainAddresses: update icon on Menu

592063d

OnChainAddresses: fix sort

0ee3a10

OnChainAddresses: link QR view

70a97ca

OnChainAddress: next address + wire up all interfaces

a125325

AddressUtils: snakeToHumanReadable

53831a2

kaloudis requested a review from shubhamkmr04 September 25, 2024 02:35

OnChainAddresses: add keys

8a404d1

shubhamkmr04 reviewed Sep 26, 2024

View reviewed changes

views/OnChainAddresses.tsx Show resolved Hide resolved

shubhamkmr04 reviewed Sep 26, 2024

View reviewed changes

kaloudis added 2 commits September 26, 2024 11:10

OnChainAddresses: fix refresh

6c3e692

OnChainAddresses: don't hide main groups when hiding 0-balance

393c356

kaloudis requested a review from shubhamkmr04 September 26, 2024 16:02

shubhamkmr04 reviewed Sep 27, 2024

View reviewed changes

OnChainAddresses: create address button when no addresses available

97305d5

shubhamkmr04 reviewed Sep 27, 2024

View reviewed changes

kaloudis merged commit 10f3f4d into ZeusLN:master Sep 27, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New screen: On-chain addresses #2242

New screen: On-chain addresses #2242

myxmaster commented Jun 15, 2024 •

edited by kaloudis

Loading

myxmaster commented Aug 14, 2024

kaloudis commented Aug 28, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis left a comment

kaloudis commented Sep 18, 2024

kaloudis Sep 22, 2024

kaloudis Sep 22, 2024

kaloudis commented Sep 22, 2024

kaloudis commented Sep 25, 2024

shubhamkmr04 left a comment •

edited

Loading

shubhamkmr04 left a comment

kaloudis commented Sep 26, 2024

shubhamkmr04 left a comment

shubhamkmr04 commented Sep 27, 2024

kaloudis commented Sep 27, 2024

shubhamkmr04 left a comment

New screen: On-chain addresses #2242

New screen: On-chain addresses #2242

Conversation

myxmaster commented Jun 15, 2024 • edited by kaloudis Loading

Description

Checklist

Testing

Locales

Third Party Dependencies and Packages

Other:

myxmaster commented Aug 14, 2024

kaloudis commented Aug 28, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis commented Sep 18, 2024

kaloudis left a comment

Choose a reason for hiding this comment

kaloudis commented Sep 18, 2024

kaloudis Sep 22, 2024

Choose a reason for hiding this comment

kaloudis Sep 22, 2024

Choose a reason for hiding this comment

kaloudis commented Sep 22, 2024

kaloudis commented Sep 25, 2024

shubhamkmr04 left a comment • edited Loading

Choose a reason for hiding this comment

shubhamkmr04 left a comment

Choose a reason for hiding this comment

kaloudis commented Sep 26, 2024

shubhamkmr04 left a comment

Choose a reason for hiding this comment

shubhamkmr04 commented Sep 27, 2024

kaloudis commented Sep 27, 2024

shubhamkmr04 left a comment

Choose a reason for hiding this comment

myxmaster commented Jun 15, 2024 •

edited by kaloudis

Loading

shubhamkmr04 left a comment •

edited

Loading