LSPS1: Change token to discount code #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update the label on Settings/LSP as well. I believe it's currently using string |
kaloudis
requested changes
Jul 8, 2024
locales/en.json
Outdated
| @@ -982,7 +982,7 @@ | |||
| "views.LSPS1.requiredChannelConfirmations": "Required channel confirmations", | |||
| "views.LSPS1.minFundingConfirmWithingBlocks": "Min funding confirm within blocks", | |||
| "views.LSPS1.minRequiredChannelConfirmations": "Min required channel confirmations", | |||
| "views.LSPS1.token": "Token", | |||
| "views.LSPS1.token": "Discount code", | |||
There was a problem hiding this comment.
Since we're rewriting the string entirely, let's rename it - maybe general.discountCode. Let's also delete views.Settings.LSP.lspAccessKey if it's not longer being used so translators don't have to translate it
kaloudis
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.