ContactStore #2283
Merged
ContactStore #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somewhat on the right track, but the initial loading of contacts should happen when the wallet loads up. We don't want to read from encrypted storage every time we go to contact details, we just want to read from the store |
…t on saving/updating contacts
shubhamkmr04
force-pushed
the
shubham/ContactStore
branch
from
003b376
to
9ed6de7
Compare
kaloudis
reviewed
Aug 15, 2024
stores/ContactStore.ts
Outdated
| : []; | ||
|
|
||
| if (isEdit && this.prefillContact && !isNostrContact) { | ||
| console.log('heree', this.prefillContact); |
kaloudis
requested changes
Aug 28, 2024
views/Settings/Contacts.tsx
Outdated
| @@ -463,7 +438,7 @@ export default class Contacts extends React.Component< | |||
| secondary | |||
| /> | |||
| )} | |||
| {loading ? ( | |||
| {ContactStore?.loading ? ( | |||
There was a problem hiding this comment.
since loading is used twice (here and 405), let's destructure it on line 206
kaloudis
requested changes
Aug 28, 2024
views/ContactDetails.tsx
Outdated
| @@ -672,8 +681,10 @@ export default class ContactDetails extends React.Component< | |||
| <Button | |||
| onPress={() => { | |||
| navigation.goBack(); | |||
| ContactStore.setPrefillContact( | |||
There was a problem hiding this comment.
since setPrefillContact is used twice (here and 242), let's destructure it at the top of the render function
kaloudis
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.