Link Channel to the stored contacts #2299
Conversation
shubhamkmr04
changed the title
|
Can you please add a description of the change and some screenshots or video illustrating the change? |
added a description and a demo picture |
views/Channels/Channel.tsx
Outdated
| @@ -295,6 +364,17 @@ export default class ChannelView extends React.Component< | |||
| </Text> | |||
| </TouchableOpacity> | |||
| )} | |||
| <Text | |||
There was a problem hiding this comment.
I really like the display component here but i don't think we need the label. Let's remove Matching Contact Found
locales/en.json
Outdated
| @@ -432,6 +432,7 @@ | |||
| "views.Channel.Total.offline": "Total offline", | |||
| "views.Channel.zeroConf": "Zero conf", | |||
| "views.Channel.commitmentType": "Commitment Type", | |||
| "views.Channel.matchingContactFound": "Matching Contact Found", | |||
There was a problem hiding this comment.
we're no longer using this locale now
shubhamkmr04
force-pushed
the
shubham/link-channel-pubkey-to-contact
branch
from
02b441f
to
6997503
Compare
|
Initial tests look good. We're gonna have to refactor this with the |
views/Channels/Channel.tsx
Outdated
| this.loadContacts(); | ||
| } | ||
|
|
||
| loadContacts = async () => { |
There was a problem hiding this comment.
Please rebase and refactor to use the newly added ContactStore
…link-channel-pubkey-to-contact
views/Channels/Channel.tsx
Outdated
| componentDidMount() { | ||
| const { ContactStore } = this.props; | ||
| const { loadContacts } = ContactStore; | ||
| loadContacts(); |
There was a problem hiding this comment.
Why do we have to load contacts again on page load? Aren't they accessible in the store already?
There was a problem hiding this comment.
yeahh. you're right. lemme change that
shubhamkmr04
force-pushed
the
shubham/link-channel-pubkey-to-contact
branch
from
5b7977c
to
e82d2c0
Compare
This PR addresses #2082
It adds functionality to link the
remotePubkeyin the Channel view to a contact from our stored contacts.It retrieves contacts from the encrypted storage, matches the
remotePubkeywith contact pubkey, and displays the contact name next to remotePubkey if a match is found.Check out the demo picture below addressing the change