Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal to dismiss custodial wallet warning #2394

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

shubhamkmr04
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 commented Sep 5, 2024

Relates to issue: ZEUS-2344

We have added a modal which will dismiss the custodial wallet warning

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@shubhamkmr04 shubhamkmr04 force-pushed the shubham/custodial-wallet-warning branch from 0f4f8c2 to 3b65110 Compare September 5, 2024 15:27
@shubhamkmr04
Copy link
Contributor Author

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-05.at.20.57.58.mp4

Demo video just for the UI update

@kaloudis
Copy link
Contributor

kaloudis commented Sep 6, 2024

After you hit 'Dismiss warning' it should kick you out to the main wallet view

@shubhamkmr04 shubhamkmr04 marked this pull request as ready for review September 10, 2024 17:21
@action
public dismissWarning = () => {
this.dismissCustodialWarning = true;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it stands now, this will not persist across restarts of the app. this needs to be saved to local storage on per node/account basis

stores/SettingsStore.ts Outdated Show resolved Hide resolved
@kaloudis kaloudis added this to the v0.9.1 milestone Sep 12, 2024
Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit ab216cb into ZeusLN:master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants