Skip to content

Commit

Permalink
Bump template dependency version (facebook#11415)
Browse files Browse the repository at this point in the history
  • Loading branch information
shfshanyue authored and abhiisheek committed May 24, 2023
1 parent 8d596e6 commit 92cd298
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion packages/confusing-browser-globals/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ If you use Create React App, you don't need to configure anything, as this rule
If you maintain your own ESLint configuration, you can do this:

```js
var restrictedGlobals = require('confusing-browser-globals');
const restrictedGlobals = require('confusing-browser-globals');

module.exports = {
rules: {
Expand Down
18 changes: 9 additions & 9 deletions packages/cra-template-typescript/template.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"package": {
"dependencies": {
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^11.1.0",
"@testing-library/user-event": "^12.1.10",
"@types/node": "^12.0.0",
"@types/react": "^17.0.0",
"@types/react-dom": "^17.0.0",
"@types/jest": "^26.0.15",
"typescript": "^4.1.2",
"web-vitals": "^1.0.1"
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@testing-library/user-event": "^13.2.1",
"@types/jest": "^27.0.1",
"@types/node": "^16.7.13",
"@types/react": "^17.0.20",
"@types/react-dom": "^17.0.9",
"typescript": "^4.4.2",
"web-vitals": "^2.1.0"
},
"eslintConfig": {
"extends": ["react-app", "react-app/jest"]
Expand Down
8 changes: 4 additions & 4 deletions packages/cra-template/template.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"package": {
"dependencies": {
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^11.1.0",
"@testing-library/user-event": "^12.1.10",
"web-vitals": "^1.0.1"
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@testing-library/user-event": "^13.2.1",
"web-vitals": "^2.1.0"
},
"eslintConfig": {
"extends": ["react-app", "react-app/jest"]
Expand Down
2 changes: 1 addition & 1 deletion packages/create-react-app/createReactApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ function run(
},
[root, appName, verbose, originalDirectory, templateName],
`
var init = require('${packageName}/scripts/init.js');
const init = require('${packageName}/scripts/init.js');
init.apply(null, JSON.parse(process.argv[1]));
`
);
Expand Down
6 changes: 3 additions & 3 deletions packages/create-react-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@

'use strict';

var currentNodeVersion = process.versions.node;
var semver = currentNodeVersion.split('.');
var major = semver[0];
const currentNodeVersion = process.versions.node;
const semver = currentNodeVersion.split('.');
const major = semver[0];

if (major < 14) {
console.error(
Expand Down

0 comments on commit 92cd298

Please sign in to comment.