Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry to submodule cloning #1636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

allenb-epilog
Copy link

When using actions/checkout@v3 or v4 we experience intermittent failures on workflows cloning submodules. The failures result in following error: unable to access <SUBMODULE REPO URL>: gnutls_handshake() failed: Error in the pull function.

Our environment is primarily self hosted runners using the action_controller_runner,

Re-running the workflows failed steps resolves the issues every time we've tried it. This PR adds the same retry logic that is used with the normal fetch flow used by the actions/checkout action. I have verified this change resolves the intermittent failures and passes the format-check, lint, and test steps described in the test.yml workflow.

@allenb-epilog allenb-epilog requested a review from a team as a code owner March 1, 2024 23:00
@brianjmurrell
Copy link

This would be a good addition as even pulling from GitHub on a GH runner can have intermittent failures that would resolve on a retry.

What more needs to be done with this PR to get it landed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants