Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull upstream #2178

Merged
merged 22 commits into from
Oct 5, 2022
Merged

Pull upstream #2178

merged 22 commits into from
Oct 5, 2022

Commits on Aug 23, 2022

  1. Escaping key and quoting it to avoid key based command injection (#2062)

    * escaping key and quoting it to avoid key based command injection
    
    * extracted creation of flags to DockerUtil, with testing included
    nikola-jokic committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    01fd044 View commit details
    Browse the repository at this point in the history
  2. Release notes for 2.296.0 (#2078)

    * Update releaseNote.md
    
    * Update runnerversion
    AvaStancu committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    cba19c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    5989479 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. docker: escape key-value pair as -e KEY and VALUE being environment v…

    …ar (#2091)
    
    * docker: escape key-value pair as -e KEY and VALUE being environment var
    
    * removed code duplication, removed unused method and test
    nikola-jokic committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    95459de View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. 2.296.1 Release (#2092) (#2099)

    * docker: escape key-value pair as -e KEY and VALUE being environment var
    
    * removed code duplication, removed unused method and test
    
    * add release notes
    
    Co-authored-by: Nikola Jokic <nikola-jokic@github.com>
    
    Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
    Co-authored-by: Nikola Jokic <nikola-jokic@github.com>
    3 people committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    5e0c2ef View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    7578675 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Port hotfix to main branch (#2108)

    * fix issue with env's overwriting environment
    
    * add release notes
    
    * handle value escaping
    
    * compile regex for runtime perf improvements
    thboop committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ed191b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    6e6410d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Configuration menu
    Copy the full SHA
    32845a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6cdd272 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a1c897 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    0678e8d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Configuration menu
    Copy the full SHA
    15cbadb View commit details
    Browse the repository at this point in the history
  2. POC: Windows arm64 runner build (#2022)

    Prerelease for windows-arm64 runner build
    thboop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    ae2f4a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc67f99 View commit details
    Browse the repository at this point in the history
  4. 2.297.0 release notes (#2155)

    * 2.297.0 release notes
    thboop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    01ff38f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Adding a new vars context for non-secret variables (#2096)

    * Adding a new vars context for non-secret variables
    
    * Fix test case
    
    * Trigger checks
    
    * Remove variables from env context and environment varibale
    
    * remove extra references
    
    * Add prefix handling to configuration variables
    
    * Fix test cases
    
    * Consume variables using vars in context data
    
    * removed action_yaml changes
    tauhid621 committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    dca4f67 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Avastancu/joannaakl/service container error log (#2110)

    * adding support for a service container docker logs
    
    * Adding Unit test to ContainerOperationProvider
    
    * Adding another test to ContainerOperationProvider
    
    * placed the docker logs output in dedicated ##group section
    
    * Removed the exception thrown if the service container was not healthy
    
    * Removed duplicated logging to the executionContext
    
    * Updated the container logs sub-section message
    
    * Print service containers only if they were healthy
    Unhealthy service logs are printed in ContainerHealthCheckLogs called prior to this step.
    
    * Removed recently added method to inspect docker logs
    The method was doing the same thing as the existing DockerLogs method.
    
    * Added execution context error
    This will make a failed health check more visible in the UI without disrupting the execution of the program.
    
    * Removing the section 'Waiting for all services to be ready'
    
    Since nested subsections are not being displayed properly and we already need one subsection per service error.
    
    * Update src/Runner.Worker/Container/DockerCommandManager.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Test/L0/TestHostContext.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Change the logic for printing Service Containers logs
    
    Service container logs will be printed in the 'Start containers' section only if there is an error.
    Healthy services will have their logs printed in the 'Stop Containers' section.
    
    * Removed unused import
    
    * Added back section group.
    
    * Moved service containers error logs to separate group sections
    
    * Removed the test testing the old logic flow.
    
    * Remove unnecessary 'IsAnyUnhealthy' flag
    
    * Remove printHello() function
    
    * Add newline to TestHostContext
    
    * Remove unnecessary field 'UnhealthyContainers'
    
    * Rename boolean flag indicating service container failure
    
    * Refactor healthcheck logic to separate method to enable unit testing.
    
    * Remove the default value for bool variable
    
    * Update src/Runner.Worker/ContainerOperationProvider.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Runner.Worker/ContainerOperationProvider.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Rename Healthcheck back to ContainerHealthcheck
    
    * Make test sequential
    
    * Unextract the container error logs method
    
    * remove test asserting thrown exception
    
    * Add configure await
    
    * Update src/Test/L0/Worker/ContainerOperationProviderL0.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Test/L0/Worker/ContainerOperationProviderL0.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Test/L0/Worker/ContainerOperationProviderL0.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Test/L0/Worker/ContainerOperationProviderL0.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Update src/Test/L0/Worker/ContainerOperationProviderL0.cs
    
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    
    * Add back test asserting exception
    
    * Check service exit code if there is no healtcheck configured
    
    * Remove unnecessary healthcheck for healthy service container
    
    * Revert "Check service exit code if there is no healtcheck configured"
    
    This reverts commit fec24e8.
    
    Co-authored-by: Ava S <avastancu@github.com>
    Co-authored-by: Tingluo Huang <tingluohuang@github.com>
    3 people committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9492691 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Configuration menu
    Copy the full SHA
    920fba9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4935be5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1379ed2 View commit details
    Browse the repository at this point in the history
  4. Backport 2.298.1 (#2175)

    * Update releaseNote.md
    
    * Update runnerversion
    fhammerl committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    86d0ee8 View commit details
    Browse the repository at this point in the history