Create root spans allowing for override of Span identifier #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presents an alternative API to that suggested by #125. The idea here is that we would create a trace but without specifying the parent, using a new
usingTrace'
function. Then we would re-use the existingencloseSpan
function augmented by a new overridesetIdentifierSpan
function, resulting in a shape like this:where
trace
andpredetermined
are the received and already created Trace and Span identifiers, respectively.While not quite as compact as the
sendSpan
idea proposed by @TheWizardTower, I'd like to suggest that by reusing existingencloseSpan
machinery we keep the API surface a bit more contained.setStartTime
is already an outlier as an override, and so this usage probably makes sense.