Don't clear metrics before running handler #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we thought we needed to clear the telemetry metrics before running the supplied handler function. This turned out to be unnecessary, because we are of course starting a new trace when we run a handler and that by definition starts with a clean slate. Calling
clearMetrics
was, however, resulting in us throwing away metrics being added by (for example) authorization machinery before the handler function was invoked. Fixed by removing the call.