Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear metrics before running handler #131

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

istathar
Copy link
Member

@istathar istathar commented Jun 1, 2022

For some reason we thought we needed to clear the telemetry metrics before running the supplied handler function. This turned out to be unnecessary, because we are of course starting a new trace when we run a handler and that by definition starts with a clean slate. Calling clearMetrics was, however, resulting in us throwing away metrics being added by (for example) authorization machinery before the handler function was invoked. Fixed by removing the call.

@istathar istathar added bug Something isn't working core-telemetry Issues involving sending telemetry to an observability service labels Jun 1, 2022
@istathar istathar self-assigned this Jun 1, 2022
@istathar istathar merged commit f3210cc into aesiniath:main Jun 1, 2022
@istathar istathar added core-webserver Issues involving wrappers around web frameworks and removed core-telemetry Issues involving sending telemetry to an observability service labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core-webserver Issues involving wrappers around web frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant