Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overriding span start time #139

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix overriding span start time #139

merged 1 commit into from
Jul 11, 2022

Conversation

istathar
Copy link
Member

Fix bug exposed when calling setStartTime: we weren't using the revised overridden start Time when exiting from encloseSpan.

@istathar istathar added bug Something isn't working core-telemetry Issues involving sending telemetry to an observability service labels Jul 11, 2022
@istathar istathar self-assigned this Jul 11, 2022
@istathar istathar merged commit d4df44c into aesiniath:main Jul 11, 2022
@istathar istathar deleted the fix-set-time branch July 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@istathar istathar

Labels
bug Something isn't working core-telemetry Issues involving sending telemetry to an observability service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@istathar