add back linkThread for backwards compatibility
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvianna
changed the title
linkThreads for backwards compatibilitylinkThread for backwards compatibility
|
haddock does this nice thing where if there's no documentation for a function it's excluded from the rendered module documentation (but the function is still defined) assuming you have which we do. I think I'll lop the documentation off, so this is a "hidden" function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of
linkThreadwould force upstream users to make small rewrites of their applications. This little amend will mean everything old will still compile and work, hopefully without rewrites.linkThreadnow does nothing except maintain the legacy API for backwards compatibility. Exceptions are bidirectional so linkThread no longer needed.