Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation about missing Honeycomb spans #163

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

dmvianna
Copy link
Contributor

This PR adds a little Gotchas section to Core.Telemetry.Honeycomb to alert users that if they see a (missing) span in the Honeycomb UI, it may be just that that span hasn't finished executing yet.

Copy link
Member

@istathar istathar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure I agree with the sentiment

it is best to call beginTrace inside a function that will iterate continuously

but only because I think the best practices for doing larger processes (especially batch or asynchronous ones) are still emerging.

I might word this as "best to have a trace for each architecturally discrete service" but even that is only on the proviso that there is something non-deterministic between services that isn't worth measuring (or rather, isn't part of the behaviour of that [set of serivce[s]; you don't want to penalize the metrics for a service if a job waited for an hour in a queue).

Anyway, I'm not sure what's best to say here, other than "it depends" and what you've written is a great start. Merging.

@istathar istathar merged commit fa11a06 into aesiniath:main Feb 1, 2023
@dmvianna
Copy link
Contributor Author

dmvianna commented Feb 1, 2023

About

it is best to call beginTrace inside a function that will iterate continuously

I left the root span below the iteration in a long lived process overnight. I just killed it in the morning. Now I have a single trace and no good way of finding which span gave me the error I'm interested in, and which I can clearly see in the graphs.

image

image

In short, in this case, putting the root high in the hierarchy was a bad idea.

@dmvianna dmvianna deleted the missing-root-honeycomb-docs branch February 17, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants