Telemetry #60
Merged
Telemetry #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istathar
added
the
experimental
We're already using `hide` for symbols exported from Core.Program.Context so it's not a visible change to expose it from the core-program library so that others in the family can get to it.
Introduce an Event type and a Trace wrapper type as well. Event has a number of optional fields that turn it into a Span. Change logging queue from Message (which ought to be internal to Core.Program.Logging anyway) to TQueue Span for now.
This is still problematic.
Change Exporter to contain an IO action which returns an appropriately saturated Forwarder, this being the new type held in Context to process / handle individual Datum messages Because setup is run by `initializeTelemetry` we have the Context available and as such can dig things out of it including the output queue, so we no longer need to return text from the forwarder.
We will pull this value from an environment variable named HONEYCOMB_DATASET now.
They're just newtypes over Rope and not internally complex, so no need to hide that fact.
Finally, at last, resolve the race conditions encountered trying to drain the queues at shutdown.
istathar
added
core-telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new package core-telemetry and functions
eventT,debugTto send telemetry objects andwithSpanto create traces.