-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images for Ubuntu 24.04 #55
base: master
Are you sure you want to change the base?
Conversation
Why do these images build and install a standalone rocksdb library, separately from the one that is included in erlang_rocksdb? Are there versioning guarantees that need to be maintained between these? Upstream RocksDB is at version 9 something, and the image currently uses 7.10.2, while the code in erlang_rocksdb is a patched 7.7.3. |
I see this: aeternity/mnesia_rocksdb@296813e mentioning 7.10.2 so that is probably deliberate 🤔 |
Probably |
That's what I suspect. Curious if someone can confirm (and if we can drop this downloading and building of standalone rocksdb as part of the image). |
I wonder does the library supports multi-platforms (we currently only need arm64 and amd64) P.S. I didn't approved your PR as the tests of the new builds are failing |
It was originally added by Ulf in #3376. Upstream did by default link statically with RocksDB but did not compile it with LZ4 enabled, which caused our tests to fail. There's a statement in the Dockerfile for Aeternity: ENV ERLANG_ROCKSDB_OPTS "-DWITH_SYSTEM_ROCKSDB=ON -DWITH_LZ4=ON ..." that sets up this. But when building locally, it's not enabled. |
Ok, this seems to working. Should make it possibe to test Aeternity on Ubuntu 24 in CI. |
No description provided.