feature(storage): config support for generating physical volumes

[joseivanlopez]

Add support to the storage config for using a generate section for physical volumes.

"physicalVolumes": [
  { "generate": ["first-disk", "second-disk"] }
]

"physicalVolumes": [
  {
    "generate": {
      "targetDevices": ["first-disk"],
      "encryption": {
        "luks2": { "password": "12345" }
      }
    }
  }
]

The generate section allows to indicate the target devices in which to automatically create physical volumes, if needed. Agama will try to create physical volumes to allocate the defined logical volumes. If an encryption section is provided by the generate section, then the new physical volumes will be encrypted.

Notes:

• For now, physicalVolumes can contain either device aliases or a generate. In the future it will allow both.
• If there is more than one generate in the list of physical volumes, then only the first one will be considered (the rest ones are ignored). Note that the schema does not complain.

[coveralls]

Pull Request Test Coverage Report for Build 11249392029

Details

• 145 of 145 (100.0%) changed or added relevant lines in 28 files are covered.
• 7 unchanged lines in 5 files lost coverage.
• Overall coverage remained the same at 70.596%

---

Files with Coverage Reduction	New Missed Lines	%
service/lib/agama/storage/config_conversions/from_json_conversions/base.rb	1	93.75%
service/lib/agama/storage/config.rb	1	96.97%
service/lib/agama/storage/proposal.rb	1	98.2%
service/lib/y2storage/agama_proposal.rb	1	98.75%
service/lib/agama/storage/config_conversions/from_json_conversions/encryption.rb	3	94.83%

Totals
Change from base Build 11209402098:	0.0%
Covered Lines:	15836
Relevant Lines:	22432

---

💛 - Coveralls

[ancorgs]

I'm actually not sure we currently support combining manually defined PVs and generated ones. I'm pretty sure it would be technically possible but probably it does not work with the current implementation of yast/yast-storage-ng#1392.

The algorithm now can combine EXISTING PVs (for a reused VG) with generated ones (for growing that existing VG). But likely no new manual PVs and automatic ones.

I will check how hard would be to add it.

[ancorgs]

I suspect it would be easy, but I have to double check.

[ancorgs]

I checked and it would be possible by modifying the yast2-storage-ng algorithm a bit. But we decided to leave it for later, as part of a separate task internally tracked at https://trello.com/c/XAaoYdCL/578-storage-profile-improve-support-for-generating-lvm-physical-volumes

[joseivanlopez]

I have adapted the schema to allow either aliases or 'generate'.

[ancorgs]

LGTM