Fix manager service status during startup #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
reviewed
Aug 21, 2023
| @@ -58,18 +62,22 @@ def initialize(config, logger) | |||
| @logger = logger | |||
| @installation_phase = InstallationPhase.new | |||
| @service_status_recorder = ServiceStatusRecorder.new | |||
| @service_status = DBus::ServiceStatus.new.busy | |||
There was a problem hiding this comment.
This looks like the manager will only rarely be idle and safe_run will fail more often?
There was a problem hiding this comment.
I would not say rarely, but this ensures that it waits for startup phase, not?
There was a problem hiding this comment.
Yes, that's the point. It starts as busy, but it is set as idle as soon as the startup_phase finishes.
jreidinger
reviewed
Aug 21, 2023
jreidinger
approved these changes
Aug 21, 2023
mvidner
approved these changes
Aug 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #707, "Manager status on single-product scenarios".
Solution
Let the manager set the service status outside of D-Bus. It does not solve all timing issues, but the
Could not start the installation...should not happen.Testing