Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0b0 #757

Merged
merged 5 commits into from
Dec 7, 2020
Merged

Release 1.1.0b0 #757

merged 5 commits into from
Dec 7, 2020

Conversation

Pliner
Copy link
Member

@Pliner Pliner commented Dec 5, 2020

  1. Fix on_connect multiple call on acquire Fix on_connect multiple call on acquire #552
  2. Fix python 3.8 warnings Deprecation warnings in asyncio with Python 3.8 #622
  3. Bump minimum psycopg version to 2.8.4 Bump psycorg and sqlalchemy, add python 3.8, 3.9 to test matrix #754
  4. Fix Engine.release method to release connection in any way Fix Engine.release method to release connection in any way #756

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #757 (4a72ab5) into master (9c79fdd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          13       13           
  Lines        1562     1562           
  Branches      179      179           
=======================================
  Hits         1449     1449           
  Misses         81       81           
  Partials       32       32           
Impacted Files Coverage Δ
aiopg/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c79fdd...4a72ab5. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dave-shawley
Copy link

Please change the pin from psycopg2-binary to psycopg2. The state of psycopg2-binary usage in Alpine Linux is abysmal and has nearly caused me production outages that I caught a little earlier in the pipeline.

screen-yypz7 image
ref: https://pypi.org/project/psycopg2-binary/

@Pliner
Copy link
Member Author

Pliner commented Dec 7, 2020

Hi @dave-shawley,

I've read #631 about this and it seems to be vital, but let's release fixes by batches. I'm going to start working on #631 and #249 after 1.1 release as part of the next release.

OK?

@dave-shawley
Copy link

@Pliner , thanks for the quick response. Doing this in the next point release will be fine. This particular issue has been causing us a lot pain since we use Alpine Linux (non-glibc) as our primary deployment vehicle.

@Pliner Pliner marked this pull request as ready for review December 7, 2020 14:19
@Pliner Pliner changed the title Release 1.1 Release 1.1.0b Dec 7, 2020
@Pliner Pliner changed the title Release 1.1.0b Release 1.1.0b0 Dec 7, 2020
@Pliner
Copy link
Member Author

Pliner commented Dec 7, 2020

@asvetlov As we discussed, I'm going to release it as 1.1.0b0 first. Then after some testing in production I'm going to publish it as 1.1.0.

@Pliner Pliner merged commit 5ed6fd5 into master Dec 7, 2020
@Pliner Pliner deleted the release-1.1 branch December 7, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants