Avoid copying list to reverse segments when making children (#1250)

aio-libs · Oct 13, 2024 · a5de0c0 · a5de0c0
1 parent 404b542
commit a5de0c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES/1250.misc.rst b/CHANGES/1250.misc.rst
@@ -0,0 +1 @@
+1248.misc.rst
diff --git a/yarl/_url.py b/yarl/_url.py
@@ -959,7 +959,8 @@ def _make_child(self, paths: "Sequence[str]", encoded: bool = False) -> "URL":
                 )
             path = path if encoded else self._PATH_QUOTER(path)
             needs_normalize |= "." in path
-            segments = list(reversed(path.split("/")))
+            segments = path.split("/")
+            segments.reverse()
             # remove trailing empty segment for all but the last path
             segment_slice_start = int(not last and segments[0] == "")
             parsed += segments[segment_slice_start:]