Improve performance of building URLs with authority #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the fast _split_netloc method so we do not have to reparse the netloc for every property
bdraco
commented
Sep 27, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Verified new tests pass on master as well so we have bug for bug compat with the faster version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
+ Coverage 95.54% 95.56% +0.01%
==========================================
Files 30 30
Lines 4892 4911 +19
Branches 446 446
==========================================
+ Hits 4674 4693 +19
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm going to do a new release of yarl before we publish a new aiohttp with aio-libs/aiohttp#9309 (comment) fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Use the fast
_split_netlocmethod so we do not have to reparse the netloc for every property.Previously we called each
SplitResultproperty which meant each property call has to reparse thenetlocevery time. Only do it onceAre there changes in behavior for the user?
no
Related issue number
aio-libs/aiohttp#9309 (comment) will call
URL.buildwithauthoritymuch more often in a performance sensitive path.