-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid re-parsing the netloc when changing user/pass/host/port #1229
Conversation
064a8b8
to
bbf4088
Compare
CodSpeed Performance ReportMerging #1229 will improve performances by ×2Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1229 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 27 27
Lines 5084 5084
Branches 302 302
=======================================
Hits 4869 4869
Misses 189 189
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
13825d8
to
60648d4
Compare
Avoid re-parsing the netloc when changing user/pass/host/port
Do not call
val.port
,val.hostname
,val.username
, orval.password
as they reparse the netloc again, and we already have them parsed and available in our internal methods.