Fix matching issue with placeholders #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2023 15:07
…than the text before the placeholder in the template.
…than the text before the placeholder in the template.
rossbacher
commented
Jun 27, 2023
| // e.g. template value: "{something}longer" and valueToMatch: "onger". As we compare | ||
| // from back all the chars match but the template value is longer so as soon as we reach | ||
| // the end of valueToMatch before we reach the placeholder end char we need to abort. | ||
| if (k < 0 || byteArray[valueStartPos + j] != valueToMatch[k]) { |
There was a problem hiding this comment.
This is the fix.
elihart
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a match template contained a placeholder in a path element (e.g. host) and the to be matched URL element matched but was just shorter than the template (before the placeholder end) it would lead to an AIOOB Exception.
e.g.
template:
scheme://{some_value(allowed|values)}somethinglonger/one/{param}/threeurl to match
scheme://longer/one/param/threeScheme matches
host (will start to match from back) and it matches char by char bur the one in the template is longer (before the placeholder) in this case we need to avoid the AIOOB in url segment and it also does not match.