Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Allow custom cache keys, dynamic properties for images, and remove font remapping #1847

Merged
merged 4 commits into from
Jul 17, 2021

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Jul 16, 2021

This set of changes is all around composition caching:

  1. Increase the caching flexibility by allowing arbitrary cache keys.
  2. Remove the cacheKey parameter from LottieCompositionSpec.JsonString because it was ambiguous with the new cacheKey parameter.
  3. Add dynamic properties for bitmaps. This is helpful because it allows you to set a bitmap on a single LottieAnimation without overwriting the bitmap for the cacheable LottieComposition.
  4. Removed fontRemapping for rememberLottieComposition because there was no way to know how to handle caching. Instead, dynamic properties can be used.

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@gpeal gpeal merged commit 194d96d into master Jul 17, 2021
@gpeal gpeal deleted the gpeal/cache-key branch July 17, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants