Fixed the stream was not closed when the lottie animation hit the cache #2253
Conversation
| @@ -311,7 +311,7 @@ private static boolean isNightMode(Context context) { | |||
| * @see #fromJsonInputStreamSync(InputStream, String, boolean) | |||
| */ | |||
| public static LottieTask<LottieComposition> fromJsonInputStream(final InputStream stream, @Nullable final String cacheKey) { | |||
| return cache(cacheKey, () -> fromJsonInputStreamSync(stream, cacheKey)); | |||
| return cache(cacheKey, () -> fromJsonInputStreamSync(stream, cacheKey), () -> closeQuietly(stream)); | |||
There was a problem hiding this comment.
fromJsonInputStreamSync closes the stream here. Is that not sufficient for your use case?
There was a problem hiding this comment.
Thank you for reviewing.
Yes, fromJsonInputStreamSync doesn't close my stream because I set stream and cacheKey via setAnimation(InputStream stream, @Nullable String cacheKey) and hit the cache, but fromJsonInputStreamSync doesn't execute when there is cache. return from here
I also can't close my stream manually because the Lottie framework internally closes my stream via fromJsonInputStreamSync when there is no cache.
|
@ankit-gautam23 Yes, I also think that the Lottie framework should close the stream, but the framework now does not close the stream when there is a cache |
|
Thanks for the Clarification @sunlocker |
This PR fixes the stream not closing when the lottie animation hits the cache.